From: Jonas Dreßler Date: Thu, 22 Aug 2019 08:10:23 +0000 (+0200) Subject: pointerA11yTimeout: Don't stop the pie timer if it finished successfully X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~827^2^2~30 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=ea3f906f380013478d9e20e6749b8c34ef0d906a;p=gnome-shell.git pointerA11yTimeout: Don't stop the pie timer if it finished successfully If the pie timeout has finished successfully there's no need to cancel the pie animation, instead we can just wait for that animation to finish and show some visual feedback like a zoom-out animation to indicate the click afterwards. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/688 --- diff --git a/js/ui/pointerA11yTimeout.js b/js/ui/pointerA11yTimeout.js index 0546f1de4..5744ac300 100644 --- a/js/ui/pointerA11yTimeout.js +++ b/js/ui/pointerA11yTimeout.js @@ -110,8 +110,10 @@ var PointerA11yTimeout = class PointerA11yTimeout { global.display.set_cursor(Meta.Cursor.CROSSHAIR); }); - manager.connect('ptr-a11y-timeout-stopped', (manager, device, type) => { - pieTimer.stop(); + manager.connect('ptr-a11y-timeout-stopped', (manager, device, type, clicked) => { + if (!clicked) + pieTimer.stop(); + if (type == Clutter.PointerA11yTimeoutType.GESTURE) global.display.set_cursor(Meta.Cursor.DEFAULT); });